RFR: 8183569: Assert the same limits are used in parse_xss and globals.hpp [v5]

[Thomas Stuefe]

On Tue, 2 Mar 2021 01:37:08 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> We have the following in Arguments::parse_xss():
>> 
>>   const julong min_ThreadStackSize = 0;
>>   const julong max_ThreadStackSize = 1 * M;
>>   const julong min_size = min_ThreadStackSize * K;
>>   const julong max_size = max_ThreadStackSize * K;
>> 
>> which duplicates the min/max range specified in globals.hpp:
>> 
>>   product_pd(intx, ThreadStackSize, \
>>           "Thread Stack Size (in Kbytes)") \
>>           range(0, 1 * M) \
>> 
>> I added an API to query the min/max range of a flag, so parse_xss can be rewritten as
>> 
>>   const JVMTypedFlagLimit<intx>* limit = 
>>     JVMFlagLimit::get_range_at(FLAG_MEMBER_ENUM(ThreadStackSize))->cast<intx>();
>>   const julong min_size = limit->min() * K;
>>   const julong max_size = limit->max() * K;
>
> Ioi Lam has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

Looks good to me. Sorry for the delay.

Cheers, Thomas

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2688