RFR: 8263054: [testbug] SharedArchiveConsistency.java reuses jsa files

[David Holmes]

On Fri, 5 Mar 2021 02:36:36 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> SharedArchiveConsistency.java runs a child process with a JSA file. Then, it modifies the JSA file, and then reuses this same JSA file to run another child process.
> 
> However, on Windows, after first child process has exited, some sort of file lock is still held on the JSA file, so when we try to modify the JSA file for the second process, sometimes we get the "The requested operation cannot be performed on a file with a user-mapped section open" error.
> 
> The fix is to always create a new JSA file for every new test case, and never modify/reuse the JSA files. (We have been following this rule for other CDS tests).

Hi Ioi,

Seems reasonable. One comment below.

Thanks,
David

test/hotspot/jtreg/runtime/cds/appcds/SharedArchiveConsistency.java line 293:

> 291:         }
> 292:         newJsaFile.createNewFile();
> 293:         Files.copy(orgJsaFile.toPath(), newJsaFile.toPath(), REPLACE_EXISTING);

Not clear why you need to create the file if you are going to immediately replace it.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2839