RFR: 8263054: [testbug] SharedArchiveConsistency.java reuses jsa files [v2]

Ioi Lam iklam at openjdk.java.net
Fri Mar 5 23:13:28 UTC 2021


> SharedArchiveConsistency.java runs a child process with a JSA file. Then, it modifies the JSA file, and then reuses this same JSA file to run another child process.
> 
> However, on Windows, after first child process has exited, some sort of file lock is still held on the JSA file, so when we try to modify the JSA file for the second process, sometimes we get the "The requested operation cannot be performed on a file with a user-mapped section open" error.
> 
> The fix is to always create a new JSA file for every new test case, and never modify/reuse the JSA files. (We have been following this rule for other CDS tests).

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8263054-SharedArchiveConsistency-testbug
 - review by David Holmes
 - 8263054: [testbug] SharedArchiveConsistency.java reuses jsa files

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2839/files
  - new: https://git.openjdk.java.net/jdk/pull/2839/files/826c7c9c..e3fdb349

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2839&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2839&range=00-01

  Stats: 802 lines in 25 files changed: 615 ins; 60 del; 127 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2839.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2839/head:pull/2839

PR: https://git.openjdk.java.net/jdk/pull/2839


More information about the hotspot-runtime-dev mailing list