RFR: 8263158: [TESTBUG] FAILED: runtime/cds/appcds/OldClassTest.java

[Ioi Lam]

On Mon, 8 Mar 2021 07:48:06 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> The fix is correct. `@run driver` should be used only for those tests that are known to be very simple and can work without any special modules settings. The test should be changed to `@run main/othervm` because it relies on the `@modules java.base/jdk.internal.org.objectweb.asm` setting.
>> 
>> Please see my comments in https://bugs.openjdk.java.net/browse/JDK-8263158 for details.
>
> Thanks @iklam for the investigation, it makes sense. 
> 
> As far as [I know](https://openjdk.java.net/jtreg/faq.html#4.29), `@run driver` is the same as `@run main` with the exception that any VM options specified on the command line will not be used when running the specified class. That's why I did this change. 
> 
> AgentVM and OtherVM are how jtreg starts the JVM(a brand new? or retrieve from the pool?), they should not affect this test. i.e. `@run main xxx` should also work for this test case.

I think this qualifies as a "trivial change" under the HotSpot project rules. The changes can be integrated with just one reviewer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2866