RFR: 8262454: Handshake timeout improvements, single target, kill unfinished thread
Robbin Ehn
rehn at openjdk.java.net
Tue Mar 9 07:26:06 UTC 2021
On Mon, 8 Mar 2021 22:40:05 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
> Looks good!
Thanks!
> test/hotspot/jtreg/runtime/handshake/HandshakeTimeoutTest.java line 83:
>
>> 81: int i = 0;
>> 82: while (true) {
>> 83: i++;
>
> Are we relying on the fact that the timeout is small (1ms) and so at some point one of the HandshakeALotClosure operations should timeout?
> Otherwise you could do as in TestAbortVMOnSafepointTimeout.java and use "wb.waitUnsafe(waitTime)" so that it will timeout right away.
Yes, good, thanks, I'll do that! (funny I think I added waitUnsafe but didn't remember that :) )
-------------
PR: https://git.openjdk.java.net/jdk/pull/2743
More information about the hotspot-runtime-dev
mailing list