RFR: 8261937: LambdaForClassInBaseArchive: SimpleApp$$Lambda$1 missing [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Tue Mar 9 21:58:11 UTC 2021


On Tue, 9 Mar 2021 21:48:23 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Please review this simple test fix to handle the situation if other lambda proxy classes loaded prior to the one from the test.
>> 
>> The fix passed mach5 tier1 and 2 testing.
>> 
>> Thanks!
>> Calvin
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   improves the shouldMatch

Marked as reviewed by dcubed (Reviewer).

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LambdaForClassInBaseArchive.java line 78:

> 76:             .assertNormalExit(out -> {
> 77:                     out.shouldHaveExitValue(0)
> 78:                        .shouldMatch("Archiving hidden SimpleApp[$][$]Lambda[$][\\d+]*");

That a zero-or-more digit match or a one-or-more digit match?
I think the pattern should require 1 or more digits.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2897


More information about the hotspot-runtime-dev mailing list