RFR: 8261918: two runtime/cds/appcds/VerifierTest failed with "Unable to use shared archive" [v2]

[Calvin Cheung]

> In the VerifierTest_*.java, we only dump the static archive once. When the -Xverify setting has changed for the dynamic archive, the static archive cannot be used due to different -Xverify settings in the following check in filemap.cpp:
> 
>   if (_has_platform_or_app_classes && 
>       ((!_verify_local && BytecodeVerificationLocal) || 
>        (!_verify_remote && BytecodeVerificationRemote))) { 
>     FileMapInfo::fail_continue("The shared archive file was created with less restrictive " 
>                   "verification setting than the current setting."); 
>     return false; 
>   } 
> The changes in TestCommon.java is to look for the -Xverify options in the input opts.suffix. If there exists -Xverify options and "DYNAMIC_DUMP", it will dump the static archive again using the new -Xverify option(s). 
> 
> This change also separates the above condition into 2; the `_has_platform_or_app_classes` should only be tied to `BytecodeVerificationRemote`.
> 
> Passed mach5 tiers 1 - 4 tests.
> 
> Thanks,
> Calvin

Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:

  1. remove unused MAP_FAIL from VerifierTest.java;
  2. move the captureVerifyOpts() call to inside the DYNAMIC_DUMP block.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2903/files
  - new: https://git.openjdk.java.net/jdk/pull/2903/files/d6a4701e..48a2a191

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2903&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2903&range=00-01

  Stats: 5 lines in 2 files changed: 1 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2903.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2903/head:pull/2903

PR: https://git.openjdk.java.net/jdk/pull/2903