RFR: 8262454: Handshake timeout improvements, single target, kill unfinished thread [v2]

[Robbin Ehn]

On Wed, 10 Mar 2021 02:52:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Overall this looks good. I'll approve the final version.
> 
> Thanks,
> David

Thanks!

> src/hotspot/share/runtime/handshake.cpp line 197:
> 
>> 195: 
>> 196:   if (target != NULL) {
>> 197:     if (os::signal_thread(target, SIGILL, "cannot be handshaked")) {
> 
> Note this is a no-op on Windows. Not sure if you want to conditionalize this or not.

This is the same way we do it in safepoint.cpp. Also it's a bit cleaner without, so I'll keep it this way.

> test/hotspot/jtreg/runtime/handshake/HandshakeTimeoutTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
> 
> 2021

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/2743