RFR: 8262454: Handshake timeout improvements, single target, kill unfinished thread [v2]
David Holmes
dholmes at openjdk.java.net
Wed Mar 10 09:48:09 UTC 2021
On Wed, 10 Mar 2021 08:59:31 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> When executing a single target handshake we do not have a timeout.
>> When we timeout we should crash the thread with the non-completed handshake operation.
>>
>> VM_Handshake only had one implementer so I remove it.
>>
>> Passes t1-5.
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Fixed cr year
> - Merge branch 'master' into 8262454-hs-timeout-st
> - Use WB waitUnsafe to trigger timeout
> - Merge branch 'master' into 8262454-hs-timeout-st
> - Fixed timeout
One typo below otherwise LGTM!
Thanks,
David
test/hotspot/jtreg/runtime/handshake/HandshakeTimeoutTest.java line 85:
> 83: public void run() {
> 84: while (true) {
> 85: // If there is a safepoint this thread might still beable to perform
typo: beable
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2743
More information about the hotspot-runtime-dev
mailing list