RFR: 8263460: DynamicArchiveRelocationTest.java fails in product VM [v2]

[Daniel D.Daugherty]

On Fri, 12 Mar 2021 17:36:22 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Please review this test bug. 
>> 
>> The handling of -XX:ArchiveRelocationMode=1 is different between fastdebug and product builds:
>> 
>> - fastdebug: (to improve test coverage) -- we always map at the default location, then unmap, and then map again at a random location.
>> - product: (for faster performance) -- don't attempt to map at the default location. Just map at random location
>> 
>> Therefore, the "unmap" messages are not available in product mode.
>> 
>> I added comments to explain what output is expected, and rearranged the regexp for better matching.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed pattern matching for "Unmapping" as these may not always happen due to ASLR

It looks to me like you've done this:

> Therefore, I decided to get rid of the pattern matching altogether

so thumbs up!
I presume you've tested the latest version with 'release' bits.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2947