RFR: 8263556: remove `@modules java.base` from tests

Igor Ignatyev iignatyev at openjdk.java.net
Mon Mar 15 17:08:09 UTC 2021


On Mon, 15 Mar 2021 16:25:48 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this trivial cleanup?
>> from JBS:
>> 
>>> jtreg `@modules X` directive does two things: 
>>>  - exclude a test from execution if JDK under test doesn't have module X 
>>>  - if JDK under test has module X, make sure it's resolved 
>>> 
>>> both these things have no sense for `java.base` module as it's always available and is always resolved.
>> 
>> 
>> Thanks,
>> -- Igor
>
> Marked as reviewed by iris (Reviewer).

Iris, Naoto, Dan, thank you for your reviews!

-- Igor

-------------

PR: https://git.openjdk.java.net/jdk/pull/2990


More information about the hotspot-runtime-dev mailing list