RFR: JDK-8262326: MaxMetaspaceSize does not have to be aligned to metaspace commit alignment

Thomas Stuefe stuefe at openjdk.java.net
Mon Mar 15 17:23:10 UTC 2021


On Mon, 15 Mar 2021 17:12:12 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Currently MaxMetaspaceSize is aligned to commit alignment in Metaspace::ergo_initialize(). 
>> 
>> That is unnecessary. MaxMetaspaceSize is just a number to compare the metaspace commit charge against. The fact that we commit in discrete uniform steps (since JEP-387, the size of a commit granule) makes no difference to that comparison.
>> 
>> This alignment introduced subtle display errors where the default value of max_uintx was aligned down, and that not-quite-max_uintx was not recognized to mean "infinite" (see JDK-8262099).
>> 
>> -----------
>> 
>> Tests: GA, nightlies at SAP
>
> LGTM

Thanks Ioi!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2721


More information about the hotspot-runtime-dev mailing list