RFR: JDK-8263559: Add missing initializers to VM_PopulateDumpSharedSpace [v2]

Coleen Phillimore coleenp at openjdk.java.net
Mon Mar 15 20:54:10 UTC 2021


On Mon, 15 Mar 2021 07:24:32 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Trivial.
>> 
>> Sonarcloud reports missing initializers in VM_PopulateDumpSharedSpace. I don't see how this could lead to an error, since these members are initialized later, but for cleanliness sake lets initialize them.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove explicit NULL resets

LGTM!

src/hotspot/share/memory/metaspaceShared.cpp line 395:

> 393:     _closed_archive_heap_oopmaps(NULL),
> 394:     _open_archive_heap_oopmaps(NULL)
> 395:   { }

The { } should go on line 394, since { is always on the declaration line.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2996


More information about the hotspot-runtime-dev mailing list