RFR: 8256732: Zero: broken +ZeroTLAB exposes badly initialized memory [v4]

David Holmes dholmes at openjdk.java.net
Tue Mar 16 09:15:21 UTC 2021


On Tue, 16 Mar 2021 09:09:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Refactor TLAB allocation code a bit
>>  - Adjust for the fact ThreadLocalAllocBuffer can mangle object space
>>  - Merge branch 'master' into JDK-8256732-zero-zerotlab-broken
>>  - Merge branch 'master' into JDK-8256732-zero-zerotlab-broken
>>  - Maintain the body/header initialization order
>>  - 8256732: Zero: broken +ZeroTLAB exposes badly initialized memory
>
> Marked as reviewed by dholmes (Reviewer).

Sorry clicked too soon and hadn't added this comment. :)

I still think there is some underlying bug here with regards to ZeroTLAB but otherwise the changes you have made seem okay, and the proof as always is in the testing, so I've approved it.

Cheers,
David

-------------

PR: https://git.openjdk.java.net/jdk/pull/1343


More information about the hotspot-runtime-dev mailing list