RFR: 8261480: MetaspaceShared::preload_and_dump should check exceptions [v2]

[David Holmes]

On Wed, 17 Mar 2021 01:03:26 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/classfile/classLoaderExt.cpp line 288:
>> 
>>> 286:                                           loader_data,
>>> 287:                                           cl_info,
>>> 288:                                           THREAD);
>> 
>> I think I'd prefer to see a local introduced and then CHECK used rather than THREAD.
>
> This is our perennial problem: CHECK cannot be used on a `return` statement :-(
> 
> See [JDK-8064811](https://bugs.openjdk.java.net/browse/JDK-8064811) (Use THREAD instead of CHECK_NULL in return statements)

`InstanceKlass* k = KlassFactory::create_from_stream(stream, name, loader_data, cl_info, CHECK);`
`return k;`

-------------

PR: https://git.openjdk.java.net/jdk/pull/2925