RFR: 8263709: Cleanup THREAD/TRAPS/CHECK usage in JRT_ENTRY routines
David Holmes
dholmes at openjdk.java.net
Thu Mar 18 03:03:55 UTC 2021
All JRT_ENTRY routines are required to have a parameter, "JavaThread* thread", which must be the current thread. The JRT_ENTRY, and related macros, then use this parameter and also expose it as THREAD for use with exception macros. But the fact "thread" is the current thread is lost in some routines and we see strange calls to other code that pass both "thread" and "THREAD" as distinct parameters - primarily when a TRAPS method is involved.
This should be cleaned up along with a general check on misuse of TRAPS/THREAD.
Testing: tiers 1-3
Thanks,
David
-------------
Commit messages:
- 8263709: Cleanup THREAD/TRAPS/CHECK usage in JRT_ENTRY routines
Changes: https://git.openjdk.java.net/jdk/pull/3062/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3062&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8263709
Stats: 110 lines in 6 files changed: 12 ins; 15 del; 83 mod
Patch: https://git.openjdk.java.net/jdk/pull/3062.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3062/head:pull/3062
PR: https://git.openjdk.java.net/jdk/pull/3062
More information about the hotspot-runtime-dev
mailing list