RFR: 8263771: Refactor javaClasses initialization code to isolate dumping code

[Ioi Lam]

On Thu, 18 Mar 2021 06:12:18 GMT, David Holmes <dholmes at openjdk.org> wrote:

> There is code in javaClasses that has a regular path and a CDS dump path. The latter is executed by the VMThread and can never throw exceptions, while the former can. If we refactor this we can simplify the exception management code. 
> 
> Testing: 
>  - runtime/cds locally
>  - tiers 1-3
> 
> Thanks,
> David

Looks good to me. Just a small nit.

src/hotspot/share/classfile/javaClasses.cpp line 830:

> 828: #ifdef ASSERT
> 829: inline static void assert_valid_fd(fieldDescriptor* fd) {
> 830:   assert(fd->has_initial_value(), "caller should have checked this");

I think it's better to renamed to `assert_valid_static_string_field` to be more specific.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3066