RFR: 8263771: Refactor javaClasses initialization code to isolate dumping code

[David Holmes]

On Thu, 18 Mar 2021 21:23:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I would rather have line #895 check for "if (is_java_primitive(fd->field_type())"  that ensures that future value type support will be handled correctly.
>
> Hi Lois,
> This is just a refactoring. If the scope of what constitutes a ConstantValue changes in the future then more will be needed to be done than just change that `if` condition. I would expect the ValueType work to have already hit this if it were a problem. The code in mainline is AFAICS correct and complete at this point in time.
> Thanks,
> David

Also note that any non-primitive, non-Object field type will hit the `ShouldNotReachHere` at line 888.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3066