RFR: 8263915: runtime/cds/appcds/MismatchedPathTriggerMemoryRelease.java fails on x86_32

Thomas Stuefe stuefe at openjdk.java.net
Mon Mar 22 08:19:40 UTC 2021


On Mon, 22 Mar 2021 01:46:48 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> runtime/cds/appcds/MismatchedPathTriggerMemoryRelease.java fails on x86_32 due to failure of this check [1].
> However, this check will always fail if UseCompressedClassPointers=0 [2] (e.g., on x86_32) since the class_space_rs remains unreserved.
> It would be better to fix it.
> 
> Thanks.
> Best regards,
> Jie
> 
> [1] https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/runtime/cds/appcds/MismatchedPathTriggerMemoryRelease.java#L66
> [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/memory/metaspaceShared.cpp#L1141

Hi Jie,

I think it would be better to couple this not to bitness but directly to UseCompressedClassPointers. The test should also work if we run it with a 64bit VM with compressed class pointers off.

To keep matters simple, I think one could even match either pattern always instead of making it dependent on CompressedClassPointers, but I leave this up to the CDS guys.

Thanks, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/3110


More information about the hotspot-runtime-dev mailing list