RFR: 8261479: CDS runtime code should check exceptions [v2]

Calvin Cheung ccheung at openjdk.java.net
Mon Mar 22 21:05:58 UTC 2021


> Proposed changes include:
> 
> - For the functions which could throw exceptions, the callers should pass in CHECK instead of THREAD.
> 
> - For the functions which won't throw exceptions, put THREAD as the first parameter.
>       E.g.`static bool add_unregistered_class(Thread* current, InstanceKlass* k);`
> 
> - For the functions which won't throw exceptions and don't use THREAD, just simply get rid of the TRAPS parameter.
> 
> Testing: passed tiers 1 and 2, in-progress tiers 3 and 4.

Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:

  update per review comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3097/files
  - new: https://git.openjdk.java.net/jdk/pull/3097/files/c3e2cc7f..22addf17

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3097&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3097&range=00-01

  Stats: 50 lines in 7 files changed: 3 ins; 3 del; 44 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3097.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3097/head:pull/3097

PR: https://git.openjdk.java.net/jdk/pull/3097


More information about the hotspot-runtime-dev mailing list