RFR: 8261479: CDS runtime code should check exceptions [v2]
Ioi Lam
iklam at openjdk.java.net
Mon Mar 22 23:08:41 UTC 2021
On Mon, 22 Mar 2021 22:37:29 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> src/hotspot/share/memory/metaspaceShared.cpp line 714:
>>
>>> 712: if (use_full_module_graph()) {
>>> 713: HeapShared::reset_archived_object_states(THREAD);
>>> 714: if (HAS_PENDING_EXCEPTION) {
>>
>> I think this is not necessary. If an exception is thrown, it will be be printed by `MetaspaceShared::preload_and_dump()`
>
> Do you mean I should keep the original code as follows?
>
> 712 if (use_full_module_graph()) {
> 713 HeapShared::reset_archived_object_states(CHECK);
> 714 }
Yes.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3097
More information about the hotspot-runtime-dev
mailing list