RFR: 8261479: CDS runtime code should check exceptions [v3]
Calvin Cheung
ccheung at openjdk.java.net
Tue Mar 23 01:31:52 UTC 2021
> Proposed changes include:
>
> - For the functions which could throw exceptions, the callers should pass in CHECK instead of THREAD.
>
> - For the functions which won't throw exceptions, put THREAD as the first parameter.
> E.g.`static bool add_unregistered_class(Thread* current, InstanceKlass* k);`
>
> - For the functions which won't throw exceptions and don't use THREAD, just simply get rid of the TRAPS parameter.
>
> Testing: passed tiers 1 and 2, in-progress tiers 3 and 4.
Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
@iklam review comment
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3097/files
- new: https://git.openjdk.java.net/jdk/pull/3097/files/22addf17..815b6c4a
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3097&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3097&range=01-02
Stats: 5 lines in 1 file changed: 0 ins; 4 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/3097.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3097/head:pull/3097
PR: https://git.openjdk.java.net/jdk/pull/3097
More information about the hotspot-runtime-dev
mailing list