RFR: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Tue Mar 23 14:13:42 UTC 2021


On Tue, 23 Mar 2021 01:47:45 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> @robehn - Thanks for the review and for the suggested improvements to the tests.
>> It will take me a bit of time to make and test these suggestions.
>
> Hi Dan,
>> I figured you would enjoy this 20 year old blast from the past!
> Yes, of course, but these tests look like they have been written today! :)
> 
> Thank you for making changes!
> I've just noticed one minor issue:
> 
> libSuspendWithObjectMonitorEnter.cpp
> libSuspendWithObjectMonitorWait.cpp:
> The static variables below are not used and can be removed:
>  32 static jrawMonitorID threadLock = NULL;
>  33 static char threadLockName[] = "threadLock";
> 
> Thanks,
> Serguei

@sspitsyn - Thanks for the re-review. I'll take care of the unused variables
and I'll do an audit of all three tests and look for more.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2899


More information about the hotspot-runtime-dev mailing list