RFR: 8261479: CDS runtime code should check exceptions [v4]
Ioi Lam
iklam at openjdk.java.net
Tue Mar 23 17:48:49 UTC 2021
On Tue, 23 Mar 2021 16:11:02 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Proposed changes include:
>>
>> - For the functions which could throw exceptions, the callers should pass in CHECK instead of THREAD.
>>
>> - For the functions which won't throw exceptions, put THREAD as the first parameter.
>> E.g.`static bool add_unregistered_class(Thread* current, InstanceKlass* k);`
>>
>> - For the functions which won't throw exceptions and don't use THREAD, just simply get rid of the TRAPS parameter.
>>
>> Testing: passed tiers 1 and 2, in-progress tiers 3 and 4.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>
> @dholmes-ora review comments
Latest version LGTM.
-------------
Marked as reviewed by iklam (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3097
More information about the hotspot-runtime-dev
mailing list