RFR: 8261551: Remove special CDS handling in Metaspace::allocate
David Holmes
dholmes at openjdk.java.net
Thu Mar 25 06:45:40 UTC 2021
On Thu, 25 Mar 2021 01:50:49 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> Please review this simple patch to remove the special handling of OOM conditions inside `Metaspace::allocate()` for CDS archive dumping. Now the OOM exception will be thrown normally and will be handled by `MetaspaceShared::preload_and_dump()` and `ClassListParser::parse()`.
Hi Ioi,
This seems fine. But I noticed that preload_and_dump doesn't let exceptions escape so should not itself be a TRAPS method (and it can be called with main_thread rather than THREAD).
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3185
More information about the hotspot-runtime-dev
mailing list