RFR: JDK-8263884: Clean up os::is_allocatable() across Posix platforms [v2]

Thomas Stuefe stuefe at openjdk.java.net
Thu Mar 25 08:42:07 UTC 2021


On Wed, 24 Mar 2021 07:50:47 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove unnecessary cast
>
> src/hotspot/os/posix/os_posix.cpp line 559:
> 
>> 557:   void* p = ::mmap(NULL, s, PROT_NONE,
>> 558:                    MAP_PRIVATE | MAP_NORESERVE | MAP_ANONYMOUS, -1, 0);
>> 559:   if (p == (void*)MAP_FAILED) {
> 
> No need to cast here, right?

I think you are right. Weirdly enough, POSIX nowhere states the type of MAP_FAILED; but I see that we omit the cast for void* in other places too so I'll remove it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3092


More information about the hotspot-runtime-dev mailing list