RFR: 8264142: Remove TRAPS/THREAD parameters for verifier related functions
Harold Seigel
hseigel at openjdk.java.net
Thu Mar 25 18:02:27 UTC 2021
On Thu, 25 Mar 2021 17:54:53 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Please review this small change to remove unneeded TRAPS and THREAD parameters from functions in verifier related files. This change was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.
>>
>> Thanks, Harold
>
> src/hotspot/share/classfile/classFileParser.cpp line 5636:
>
>> 5634: // its _class_name field.
>> 5635: void ClassFileParser::prepend_host_package_name(const InstanceKlass* unsafe_anonymous_host) {
>> 5636: JavaThread* current = JavaThread::current();
>
> Can you pass Thread* current as the first parameter instead? We're trying to minimize materializing the current thread.
How about if "ResourceMark rm(THREAD)" is changed to "ResourceMark rm;" ? Then no Thread* is need in the function.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3194
More information about the hotspot-runtime-dev
mailing list