RFR: 8264142: Remove TRAPS/THREAD parameters for verifier related functions

Coleen Phillimore coleenp at openjdk.java.net
Thu Mar 25 19:19:27 UTC 2021


On Thu, 25 Mar 2021 19:15:17 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review this small change to remove unneeded TRAPS and THREAD parameters from functions in verifier related files.  This change was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.
>> 
>> Thanks, Harold
>
> src/hotspot/share/classfile/verifier.cpp line 139:
> 
>> 137: void Verifier::log_end_verification(outputStream* st, const char* klassName, Symbol* exception_name) {
>> 138:    Thread* THREAD = Thread::current();
>> 139: 
> 
> This one would be better if you passed THREAD->pending_exception() as an oop.  Then you wouldn't have to have HAS_PENDING_EXCEPTION.

This is logging so I guess it doesn't really matter.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3194


More information about the hotspot-runtime-dev mailing list