RFR: 8261551: Remove special CDS handling in Metaspace::allocate [v2]

[David Holmes]

On Thu, 25 Mar 2021 17:12:46 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Please review this simple patch to remove the special handling of OOM conditions inside `Metaspace::allocate()` for CDS archive dumping. Now the OOM exception will be thrown normally and will be handled by `MetaspaceShared::preload_and_dump()` and `ClassListParser::parse()`.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove TRAPS from MetaspaceShared::preload_and_dump()

Marked as reviewed by dholmes (Reviewer).

src/hotspot/share/memory/metaspaceShared.cpp line 615:

> 613: // Preload classes from a list, populate the shared spaces and dump to a
> 614: // file.
> 615: void MetaspaceShared::preload_and_dump() {

I would have kept the Thread argument to avoid the implicit Thread::current() in EXCEPTION_MARK. But it is a margin call either way.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3185