RFR: 8264188: Improve handling of assembly files in the JDK [v2]

Mon Mar 29 10:48:56 UTC 2021

On Thu, 25 Mar 2021 16:47:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use OPENJDK_BUILD_CPU_BITS instead
>
> make/autoconf/toolchain.m4 line 887:
> 
>> 885:       # On windows, the assember is "ml.exe". We currently don't need this so
>> 886:       # do not require.
>> 887:       if test "x$OPENJDK_TARGET_CPU_BITS" = "x64"; then
> 
> If this is for the BUILD_AS, shouldn't we be checking OPENJDK_BUILD_CPU_BITS?

Yes, technically you are correct. I will update. It is a bit of an academic exercise though, since this is not being used. But still, it's good to have for consistency.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3198