RFR: 8264412: AArch64: CPU description should refer DMI
Andrew Haley
aph at openjdk.java.net
Wed Mar 31 08:48:25 UTC 2021
On Wed, 31 Mar 2021 08:43:33 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> In case of AWS A1 2x.large, board_name has `\n` (0x0A) only. This code intent to ignore it.
>
> Please be more explicit. This is (perhaps obviously?) a workaround for a bug, And t.his code is itself a bug, because it doesn't check for the condition you care about. So, please check explicitly for this condition: `\n` only, and nothing else. And leave a comment explaining why.
One other thing I missed last time around: why is there a permanently-allocated 4k buffer for this code that it only used for jfr?
-------------
PR: https://git.openjdk.java.net/jdk/pull/3259
More information about the hotspot-runtime-dev
mailing list