RFR: 8257831: Suspend with handshakes [v2]
Robbin Ehn
rehn at openjdk.java.net
Wed Mar 31 10:58:32 UTC 2021
On Tue, 30 Mar 2021 17:15:52 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
> This is an elegant evolution of the suspend/resume mechanism.
>
> It is so nice to see all the suspend-equivalent stuff go away!
Thanks Dan!
> src/hotspot/share/runtime/handshake.hpp line 37:
>
>> 35: class JavaThread;
>> 36: class ThreadSuspensionHandshake;
>> 37: class SuspendThreadHandshake;
>
> Should these be in alpha sort order?
Thanks, fixed.
> src/hotspot/share/runtime/handshake.hpp line 147:
>
>> 145: bool handshake_suspend();
>> 146: // Called from the async handshake (the trap)
>> 147: // to stop a thread from continuing executing when suspended.
>
> nit typo: s/continuing executing/continuing execution/
Thanks, Fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3191
More information about the hotspot-runtime-dev
mailing list