RFR: 8264760: JVM crashes when two threads encounter the same resolution error [v6]

Wang Huang whuang at openjdk.java.net
Thu May 6 02:05:00 UTC 2021


On Fri, 30 Apr 2021 13:26:22 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix crash problem
>
> test/hotspot/jtreg/runtime/Nestmates/membership/HostNoNestMember.java line 29:
> 
>> 27:  * HostNoNestMember$Member has a class HostNoNestMember as its
>> 28:  * NestHost, which will trigger an error when resolving .
>> 29:  */
> 
> Can you modify the above comment to something such as:
> 
> 
>  * This class was used to produce a jcod file in which the
>  * NestMembers attribute was modified to make it empty. Class
>  * HostNoNestMember$Member has class HostNoNestMember as its
>  * NestHost, which will trigger an error when resolving.
>  *
>  * When compiled, this generates a HostNoNestMember class and
>  * a HostNoNestMember$Menber class.  The former class, HostNoNestMember,
>  * gets overwritten when HostNoNestMember.jcod gets compiled.

OK. I will fix that. Thank you.

> test/hotspot/jtreg/runtime/Nestmates/membership/TestNestHostErrorWithMultiThread.java line 34:
> 
>> 32:  * @run main TestNestHostErrorWithMultiThread
>> 33:  */
>> 34: 
> 
> Please add a comment here that HostNoNestMember.jcod must be compiled after HostNoNestMember.java because the class file from the jcod file must replace the HostNoNestMember class file generated from HostNoNestMember.java.

Thank you for your review. I will add that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3392


More information about the hotspot-runtime-dev mailing list