RFR: JDK-8266503: [UL] Make Decorations safely copy-able and reduce their size [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Thu May 6 16:15:00 UTC 2021
On Thu, 6 May 2021 13:27:46 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge
>> - Remove harfbuzz build fix
>> - Volker feedback
>> - start
>> - cherry-picked JDK-8266536
>> - harfbuzz-buildfix
>
> src/hotspot/share/logging/logDecorations.cpp line 90:
>
>> 88:
>> 89: void LogDecorations::print_time_decoration(outputStream* st) const {
>> 90: char buf[29];
>
> nit: "29" might be better to define some constant e.g. "ISO8601_LEN". But it should might be better to happen in #3869.
> Looks good!
Thanks! I'll add the constant in the other PR
-------------
PR: https://git.openjdk.java.net/jdk/pull/3874
More information about the hotspot-runtime-dev
mailing list