RFR: 8265465: jcmd VM.cds should keep already dumped archive when exceptions happens [v3]
Yumin Qi
minqi at openjdk.java.net
Thu May 6 16:29:32 UTC 2021
> Hi, Please review
> When using jcmd to dump shared archive, if the archive name exists, it will be deleted first. If exception happens during dumping process, there is no new archive created. This PR changes to first dump the archive with a temporary file name. With successful dump, the temporary file will be rename to its given name. This way the old archive will not be touched on exception.
> The newly added test case skipped testing on Windows since File operation result is not same as on Linux.
>
> Tests: tier1,tier2,tier3,tier4
>
> Thanks
> Yumin
Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
Fixed temp file operation, archive and temp file name consistency
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3886/files
- new: https://git.openjdk.java.net/jdk/pull/3886/files/b420da7b..83478dd1
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3886&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3886&range=01-02
Stats: 289 lines in 5 files changed: 120 ins; 138 del; 31 mod
Patch: https://git.openjdk.java.net/jdk/pull/3886.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3886/head:pull/3886
PR: https://git.openjdk.java.net/jdk/pull/3886
More information about the hotspot-runtime-dev
mailing list