RFR: 8266252: Streamline AbstractInterpreter::method_kind [v3]

Claes Redestad redestad at openjdk.java.net
Thu May 6 23:39:04 UTC 2021


On Thu, 6 May 2021 22:53:32 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Claes Redestad has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Review comments
>>  - Merge branch 'master' into method_kind
>>  - assert that vmIntrinsics::_dsqrt are only selected for Math/StrictMath::sqrt
>>  - Improve comment
>>  - Select native as the kind for StrictMath::sqrt
>>  - Streamline AbstractInterpreter::method_kind
>
> src/hotspot/share/interpreter/abstractInterpreter.cpp line 142:
> 
>> 140:   // Native method?
>> 141:   // Note: This test must come _before_ the test for intrinsic
>> 142:   //       methods. See also comments below.
> 
> So apparently this is no longer true?

The one case of a native and intrinsic method is StrictMath::sqrt, which is handles specially above to retain the order of precedence.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3798


More information about the hotspot-runtime-dev mailing list