RFR: JDK-8266536: Provide a variant of os::iso8601_time which works with arbitrary timestamps [v4]
Thomas Stuefe
stuefe at openjdk.java.net
Fri May 7 06:11:22 UTC 2021
On Wed, 5 May 2021 18:58:49 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> feedback yasumasa and xin
>
> The API change looks good to me. I understand that this is prerequisite of your logdecoration change. make sense.
>
> I don't understand your change in harfbuzz header.
Thanks @navyxliu and @simonis and @YaSuenag for your reviews.
Last change:
- fixes the stray edit in the prototype Xin noted
- adds an explicit constant for the output buffer size of iso timestamps
@YaSuenag could you please officially approve this PR? Unfortunately, Xin is no committer yet, so I need a second reviewer.
Thanks, Thomas
-------------
PR: https://git.openjdk.java.net/jdk/pull/3869
More information about the hotspot-runtime-dev
mailing list