RFR: JDK-8266503: [UL] Make Decorations safely copy-able and reduce their size [v2]

[Thomas Stuefe]

On Thu, 6 May 2021 19:06:30 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge
>>  - Remove harfbuzz build fix
>>  - Volker feedback
>>  - start
>>  - cherry-picked JDK-8266536
>>  - harfbuzz-buildfix
>
> src/hotspot/share/logging/logTagSet.hpp line 116:
> 
>> 114: 
>> 115:   void label(outputStream* st, const char* separator = ",") const;
>> 116:   int label(char *buf, size_t len, const char* separator = ",") const;
> 
> This old label() is only used in LogTagset. You can make it private.
> 
> Further,  no one consumes its return value now.  you can change its return type to void.  It will avoid different return types for overloaded member functions.

I thought so too, but the gtests still test this interface. Seeing that its not used in the hs codebase anymore I could remove it, but would have to rewrite all gtests to use the new interface instead. I'd rather avoid this to keep the patch small. Lets do this in a different RFE.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3874