Integrated: JDK-8266536: Provide a variant of os::iso8601_time which works with arbitrary timestamps

[Thomas Stuefe]

On Wed, 5 May 2021 04:31:57 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> We have os::iso8601_time(), which gives an ISO8601 timestamp of the current time. It would be very useful to have a second variant which can be fed an arbitrary numerical timestamp.
> 
> This is useful in the context of making asynchronous UL logging cheaper (see JDK-8229517)
> 
> This patch provides an additional API: 
> `char* os::iso8601_time(jlong milliseconds_since_19700101, char* buffer, size_t buffer_length, bool utc);`
> alongside the existing
> `char* os::iso8601_time(char* buffer, size_t buffer_length, bool utc);`
> and implements the latter using the former. Not much code added.
> 
> In addition, it adds a regression gtest for these APIs.
> 
> Please ignore the harfbuzz change, its a build fix needed for older gcc, will be removed before final push.
> 
> Testing: GHA, manual gtests, SAP nightlies on all our platforms.
> 
> Thanks, Thomas

This pull request has now been integrated.

Changeset: 94c6177f
Author:    Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/94c6177f246fc569b416f85f1411f7fe031f7aaf
Stats:     81 lines in 4 files changed: 72 ins; 6 del; 3 mod

8266536: Provide a variant of os::iso8601_time which works with arbitrary timestamps

Reviewed-by: xliu, simonis, ysuenaga

-------------

PR: https://git.openjdk.java.net/jdk/pull/3869