RFR: 8208237: Re-examine defmeth tests and update as needed
David Holmes
dholmes at openjdk.java.net
Tue May 11 00:12:55 UTC 2021
On Wed, 5 May 2021 10:38:18 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
> Some test cleanups:
> - removed all `@KnownFailure`
> - narrowed expected error types in some cases
> - fixed private method invocation tests in reflection mode (got rid of `NoSuchMethodError`s in reflection mode)
> - introduced `TesterBuilder::new_()` to let the tests precisely describe the intent
> - some other minor cleanups
>
> Testing:
> - [x] defmeth tests
> - [x] hs-tier5 - hs-tier6 (include defmeth tests)
Hi Vladimir,
Great to see this cleanup happen. I couldn't verify every change naturally but in general it looks good. The proof of course is in the running of the tests.
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3879
More information about the hotspot-runtime-dev
mailing list