RFR: JDK-8266795: Remove dead code LowMemoryDetectorDisabler

David Holmes dholmes at openjdk.java.net
Tue May 11 02:33:54 UTC 2021


On Tue, 11 May 2021 01:16:27 GMT, Hamlin Li <mli at openjdk.org> wrote:

> This is trivial change to remove dead code in low memory detector.

Hi Hamlin,

What you have seems fine, but unless I missed something it seems the whole notion of being enabled/disabled is unused:

 // > 0 if temporary disabed
  static volatile jint _disabled_count;
  static bool temporary_disabled() { return _disabled_count > 0; }
  static void disable() { Atomic::inc(&_disabled_count); }
  static void enable() { Atomic::dec(&_disabled_count); }

Thanks,
David

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3964


More information about the hotspot-runtime-dev mailing list