RFR: 8262952: [macos_aarch64] os::commit_memory failure [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Tue May 11 16:37:53 UTC 2021
On Tue, 11 May 2021 16:05:24 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> On x86_64 macOS the following sequence works just fine:
>>
>> attempt_reserve_memory_at(executable=false)
>> commit_memory(executable=true)
>>
>> however, on aarch64 macOS it fails.
>>
>> We fix the test itself to explicitly ask for executable memory when reserving it since it later commits it as executable.
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>
> do not expose memory with exec priviledges unless explicitly asked for, fix the test intead to ask for exececutable memory as needed
Looks good. Thanks for fixing!
-------------
Marked as reviewed by stuefe (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3865
More information about the hotspot-runtime-dev
mailing list