RFR: 8266822: Rename MetaspaceShared::is_old_class to has_old_class_version

Calvin Cheung ccheung at openjdk.java.net
Tue May 11 17:35:27 UTC 2021


On Tue, 11 May 2021 16:53:34 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Please review this simple patch for renaming the function from `MetaspaceShared::is_old_class` to `MetaspaceShared::has_old_class_version`. Also added some comment to the function.
>> 
>> Tests:
>> - [x] tier1, 2
>
> src/hotspot/share/cds/metaspaceShared.cpp line 577:
> 
>> 575: };
>> 576: 
>> 577: // Check if a class or its super class/interface has a version older than 50.
> 
> How about "Check if a class or any of its supertypes has ...."

@iklam Thanks for the review. I'll update the comment before integration.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3983


More information about the hotspot-runtime-dev mailing list