RFR: 8266822: Rename MetaspaceShared::is_old_class to has_old_class_version [v4]

[Coleen Phillimore]

On Tue, 11 May 2021 21:00:10 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move the has_old_class_version function to InstanceKlass
>
> src/hotspot/share/oops/instanceKlass.cpp line 2583:
> 
>> 2581:     return true;
>> 2582:   }
>> 2583:   if (has_old_class_version(ik->java_super())) {
> 
> I think it's better to change this static method into an instance method, so you can call `klass->has_old_class_version()`. You'd also need to change the above "if" to
> 
> 
> if (ik->java_super() != NULL && ik->super->has_old_class_version()) {

Yes. I agree.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3983