RFR: 8266822: Rename MetaspaceShared::is_old_class to has_old_class_version [v5]

[Coleen Phillimore]

On Tue, 11 May 2021 22:07:40 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Please review this simple patch for renaming the function from `MetaspaceShared::is_old_class` to `MetaspaceShared::has_old_class_version`. Also added some comment to the function.
>> 
>> Tests:
>> - [x] tier1, 2
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   convert has_old_class_version to an instance method

Thank you for making this change!

src/hotspot/share/oops/instanceKlass.cpp line 2576:

> 2574: // retrieved during dump time.
> 2575: // Verification of archived old classes will be performed during run time.
> 2576: bool InstanceKlass::has_old_class_version() {

very small nit: Can you make this function 'const' ?

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3983