RFR: 8266822: Rename MetaspaceShared::is_old_class to has_old_class_version
David Holmes
david.holmes at oracle.com
Wed May 12 08:02:45 UTC 2021
Hi Calvin,
On 12/05/2021 2:23 am, Calvin Cheung wrote:
> Please review this simple patch for renaming the function from `MetaspaceShared::is_old_class` to `MetaspaceShared::has_old_class_version`. Also added some comment to the function.
I guess you missed the fact that I had changed the bug synopsis. Why not
call this needs_old_verifier (or something like that) so that the exact
meaning of this method is more clear?
David
> Tests:
> - [x] tier1, 2
>
> -------------
>
> Commit messages:
> - 8266822: Rename MetaspaceShared::is_old_class to has_old_class_version
>
> Changes: https://git.openjdk.java.net/jdk/pull/3983/files
> Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3983&range=00
> Issue: https://bugs.openjdk.java.net/browse/JDK-8266822
> Stats: 18 lines in 6 files changed: 4 ins; 0 del; 14 mod
> Patch: https://git.openjdk.java.net/jdk/pull/3983.diff
> Fetch: git fetch https://git.openjdk.java.net/jdk pull/3983/head:pull/3983
>
> PR: https://git.openjdk.java.net/jdk/pull/3983
>
More information about the hotspot-runtime-dev
mailing list