[11u] RFR: 8185734: [Windows] Structured Exception Catcher missing around gtest execution

[Thomas Stüfe]

Thanks a lot Martin.

On Wed, May 12, 2021 at 11:40 AM Doerr, Martin <martin.doerr at sap.com> wrote:

> Hi Thomas,
>
>
>
> your backport looks good to me.
>
>
>
> Best regards,
>
> Martin
>
>
>
>
>
> *Von: *jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> im Auftrag
> von Thomas Stüfe <thomas.stuefe at gmail.com>
> *Datum: *Dienstag, 11. Mai 2021 um 06:46
> *An: *jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
> *Cc: *Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>
> *Betreff: *[11u] RFR: 8185734: [Windows] Structured Exception Catcher
> missing around gtest execution
>
> Hi,
>
> May I please have a review for the downport of this patch. I would like to
> dowport it since it allows us to run gtests which test signal handling on
> Windows in 11u. This is a precondition for downporting "8257828 SafeFetch
> may crash if invoked in non-JavaThreads", which is also in work.
>
> JBS:            https://bugs.openjdk.java.net/browse/JDK-8185734
>
> Original patch: https://github.com/openjdk/jdk/commit/568dc29b.diff
> Original PR:    https://git.openjdk.java.net/jdk/pull/1757
>
> The original patch does not apply cleanly due to changes done in
> GTestWrapper.java in the wake of JEP 387. However, the delta is minimal
> (just one line).
>
> 11u patch:
>
> http://cr.openjdk.java.net/~stuefe/webrevs/backports/8185734-Windows-Structured-Exception-Catcher-missing-around-gtest-execution-11u.diff
>
> Thank you!
>
> Thomas
>