RFR: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report [v2]
David Holmes
dholmes at openjdk.java.net
Thu May 13 08:06:24 UTC 2021
> A simple fix to add a new VMErrorType (OOM_JAVA_HEAP_FATAL) to indicate we've requested a Java OOM error to be fatal. A new overload of report_fatal is provided to allow this to be passed through.
>
> VMError has an existing notion of "should_report_bug" but that encompasses more than just printing the bug submission URL, so I added a new specific check for that.
>
> Checked hs_err files before and after with the fix, from the CrashOnOutOfMemoryError test.
>
> Tested tiers 1-3 for good measure.
>
> Thanks,
> David
David Holmes has updated the pull request incrementally with one additional commit since the last revision:
Review comments from Thomas
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4006/files
- new: https://git.openjdk.java.net/jdk/pull/4006/files/f83eda4c..147b5cf1
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4006&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4006&range=00-01
Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
Patch: https://git.openjdk.java.net/jdk/pull/4006.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4006/head:pull/4006
PR: https://git.openjdk.java.net/jdk/pull/4006
More information about the hotspot-runtime-dev
mailing list