RFR: 8266642: improve ResolvedMethodTable hash function [v7]

Denghui Dong ddong at openjdk.java.net
Fri May 14 16:03:46 UTC 2021


On Fri, 14 May 2021 12:31:05 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor
>
> src/hotspot/share/prims/resolvedMethodTable.cpp line 56:
> 
>> 54: 
>> 55: unsigned int method_hash(const Method* method) {
>> 56:   unsigned int hash = method->method_holder()->class_loader_data()->identity_hash();
> 
> I don't see "#include classfile/classLoaderData.hpp" in your patch. Did you verify it builds successfully? I saw a compilation failure without the include:
> 
> 
> src/hotspot/share/prims/resolvedMethodTable.cpp:56:67: error: member access into incomplete type 'ClassLoaderData'
>   unsigned int hash = method->method_holder()->class_loader_data()->identity_hash();
>                                                                   ^
> src/hotspot/share/memory/allocation.hpp:260:7: note: forward declaration of 'ClassLoaderData'
> class ClassLoaderData;
>       ^
> 1 error generated.

Sorry, I only verify it with normal build parameters, and I forgot that "precompiled.hpp" might be disabled.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3901


More information about the hotspot-runtime-dev mailing list