RFR: 8265705: aarch64: KlassDecodeMovk mode broken

Ioi Lam iklam at openjdk.java.net
Fri May 14 16:41:39 UTC 2021


On Tue, 11 May 2021 07:49:35 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Hi,
> 
> may I please have a review for this aarch64-specific fix? Details see JBS issue and code comment.
> 
> I manually tested that this fix works. Patch includes a repro case.
> 
> Cheers, Thomas

Since we already have an assert to check that the range is less than 4G, can’t we set shift to zero for all platforms? BTW the assert should be changed to a guarantee so it works for product build as well.

In the future, if we want to both CDS and >4G CCS, we can revisit this.

-------------

Changes requested by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3968


More information about the hotspot-runtime-dev mailing list